[PATCH] spi: spi-mem: Introduce a default ->exec_op() debug log

[Mark Brown]

On Thu, Mar 06, 2025 at 09:05:39AM +0000, Tudor Ambarus wrote:
> On 3/5/25 8:11 PM, Miquel Raynal wrote:

> > --- a/drivers/spi/spi-mem.c
> > +++ b/drivers/spi/spi-mem.c
> > @@ -377,6 +377,17 @@ int spi_mem_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)
> >  	/* Make sure the operation frequency is correct before going futher */
> >  	spi_mem_adjust_op_freq(mem, (struct spi_mem_op *)op);
> >  
> > +	dev_dbg(&mem->spi->dev, "[cmd: 0x%02x][%dB addr: %#8llx][%dB dummy][%4dB data %s] %d%c-%d%c-%d%c-%d%c @ %uHz\n",

> Isn't this too "chatty", especially on page program ops? I wouldn't be
> surprised if the prints introduce timings that change controller's
> behavior. How about using dev_vdbg?

That, or covert to trace_printk() or even better a trace event - with a
trace event you get really fine grained control and extremely low
overhead.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20250313/00f158b5/attachment.sig>