[PATCH 1/1] mtd: spi-nand: macronix: disable continuous read for MX35LFxGE4AD

[Vignesh Raghavendra]

+ linux-mtd

Please cc linux-mtd at lists.infradead.org for all patches and queries
related to MTD subsystems.

Run ./scripts/get_maintainers.pl on the patch for more information.


On 18/06/25 15:30, Chukun Pan wrote:
> In on-die ECC mode, enabling continuous read will cause ubi_io_read error.
> [    7.852000] ubi0 warning: ubi_io_read: error -5 while reading ...
> 
> So disable it first. Tested on GL.iNet GL-MT3000 with MX35LF2GE4AD flash.

Why? this datasheet says otherwise [1]:

Would it be possible that SPI/QSPI controller of GL.iNet GL-MT3000 has a
limitation?

> 
> Fixes: 11813857864f ("mtd: spi-nand: macronix: Continuous read support")
> Signed-off-by: Chukun Pan <amadeus at jmu.edu.cn>
> ---
>  drivers/mtd/nand/spi/macronix.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/spi/macronix.c b/drivers/mtd/nand/spi/macronix.c
> index eeaf5bf9f082..cedb3d04876d 100644
> --- a/drivers/mtd/nand/spi/macronix.c
> +++ b/drivers/mtd/nand/spi/macronix.c
> @@ -187,7 +187,6 @@ static const struct spinand_info macronix_spinand_table[] = {
>  		     SPINAND_HAS_QE_BIT,
>  		     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
>  				     macronix_ecc_get_status),
> -		     SPINAND_CONT_READ(macronix_set_cont_read),
>  		     SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,
>  					macronix_set_read_retry)),
>  	SPINAND_INFO("MX35LF4GE4AD",
> @@ -200,7 +199,6 @@ static const struct spinand_info macronix_spinand_table[] = {
>  		     SPINAND_HAS_QE_BIT,
>  		     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
>  				     macronix_ecc_get_status),
> -		     SPINAND_CONT_READ(macronix_set_cont_read),
>  		     SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,
>  					macronix_set_read_retry)),
>  	SPINAND_INFO("MX35LF1G24AD",


[1]
https://www.macronix.com/Lists/Datasheet/Attachments/9046/MX35LF2GE4AD,%203V,%202Gb,%20v1.6.pdf
8-3-4. Continuous Read Operation

-- 
Regards
Vignesh
https://ti.com/opensource