[PATCH v2] mtd: spi-nor: winbond: Add support for W77Q51NW

[Marek Vasut]

On 7/22/25 10:43 AM, Michael Walle wrote:
> Hi Marek,

Hi,

>> --- a/drivers/mtd/spi-nor/winbond.c
>> +++ b/drivers/mtd/spi-nor/winbond.c
>> @@ -343,6 +343,10 @@ static const struct flash_info 
>> winbond_nor_parts[] = {
>>          .id = SNOR_ID(0xef, 0x80, 0x20),
>>          .name = "w25q512nwm",
>>          .otp = SNOR_OTP(256, 3, 0x1000, 0x1000),
>> +    }, {
>> +        /* W77Q51NW */
>> +        .id = SNOR_ID(0xef, 0x8a, 0x1a),
>> +        .otp = SNOR_OTP(256, 3, 0x1000, 0x1000),
> 
> Did you also test the OTP read and write? I'd guess so, because otherwise
> you wouldn't need that entry at all, right? Or is it because of the
> winbond_nor_late_init() which will be called as a manufacturer fixup?
> In that case we could do the same as in commit afe1ea1344bb ("mtd: spi-nor:
> add support for Macronix Octal flash").

I have limited supply of these devices, so OTP is untested. The flash 
does have OTP registers, that's why the .otp entry is there. Why should 
I remove it if the OTP registers are in the chip ?

-- 
Best regards,
Marek Vasut