[PATCH mtd-utils 2/7] nand-utils: nanddump: Fix unexpected type compiling warning for argument 'dumpfile'
Zhihao Cheng
chengzhihao1 at huawei.com
Sat Jan 25 22:41:58 PST 2025
The const pointer argument cannot be passed into libc function 'free()',
otherwise the compiler will complain following message:
nand-utils/nanddump.c:168:10: warning: passing argument 1 of ‘free’
discards ‘const’ qualifier from pointer target type
Fixes: c89009463888 ("nanddump: don't leak copied command line arguments")
Signed-off-by: Zhihao Cheng <chengzhihao1 at huawei.com>
---
nand-utils/nanddump.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/nand-utils/nanddump.c b/nand-utils/nanddump.c
index bc22858..b4de05e 100644
--- a/nand-utils/nanddump.c
+++ b/nand-utils/nanddump.c
@@ -102,6 +102,7 @@ static void process_options(int argc, char * const argv[])
{
int error = 0;
bool oob_default = true;
+ char *dumpfile_tmp = NULL;
for (;;) {
int option_index = 0;
@@ -165,8 +166,8 @@ static void process_options(int argc, char * const argv[])
start_addr = simple_strtoll(optarg, &error);
break;
case 'f':
- free(dumpfile);
- dumpfile = xstrdup(optarg);
+ free(dumpfile_tmp);
+ dumpfile = dumpfile_tmp = xstrdup(optarg);
break;
case 'l':
length = simple_strtoll(optarg, &error);
--
2.13.6
More information about the linux-mtd
mailing list