[PATCH] dt-bindings: mtd: microchip,mchp23k256: convert to DT schema
Krzysztof Kozlowski
krzk at kernel.org
Tue Dec 30 04:32:38 PST 2025
On Mon, Dec 29, 2025 at 12:49:00PM +0000, Akhila YS wrote:
> +---
> +$id: http://devicetree.org/schemas/mtd/microchip,mchp23k256.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip 23K256 (and similar) SPI SRAM MTD driver
driver? Bindings are for hardware.
> +
> +maintainers:
> + - Richard Weinberger <richard at nod.at>
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + Driver for Microchip 23K256 and compatible (e.g. 23LCV1024) serial SRAM devices
Don't describe drivers...
> + accessed via SPI. The device exposes the SRAM as an MTD device and supports
> + optional partitioning via child nodes.
nor DTS, but the hardware.
> +
> +allOf:
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
If this is SRAM, then it should go to sram directory. But maybe it is
MTD, so NOR or NAND? If so you would be missing here refs to NAND
chips.
Although docs are saying it is SRAM, so just place it there.
> +properties:
> + compatible:
> + enum:
> + - microchip,mchp23k256
> + - microchip,mchp23lcv1024
> +
> + reg:
> + maxItems: 1
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 1
Pretty incomplete. Old binding and above cells claim there can be child
nodes, so please add them and test. Works? No. Shall work? Yes... so
either old binding was incorrect or new binding is incomplete. I did not
check the driver, though.
> +
> +required:
> + - reg
> + - compatible
> + - "#address-cells"
> + - "#size-cells"
> + - spi-max-frequency
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sram at 0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
They are redundant. Where are children?
> + compatible = "microchip,mchp23k256";
> + reg = <0>;
> + spi-max-frequency = <20000000>;
> + };
> + };
> +...
>
> ---
> base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
> change-id: 20251229-nxp-526e29da9f29
>
> Best regards,
> --
> Akhila YS <akhilayalmati at gmail.com>
>
More information about the linux-mtd
mailing list