[PATCH] ubifs: Move update of cnt in get_znodes_to_commit
Waqar Hameed
waqar.hameed at axis.com
Thu Oct 17 11:41:13 PDT 2024
There is no need to update `cnt` for the first dirty node just before
the loop, and then again update it at the end of each iteration for the
next dirty nodes. Just update `cnt` at the beginning of each iteration
instead. This way, the first iteration will count the first dirty node
and any subsequent iterations will count the next dirty nodes.
Signed-off-by: Waqar Hameed <waqar.hameed at axis.com>
---
fs/ubifs/tnc_commit.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ubifs/tnc_commit.c b/fs/ubifs/tnc_commit.c
index a55e04822d16..d42f7829389c 100644
--- a/fs/ubifs/tnc_commit.c
+++ b/fs/ubifs/tnc_commit.c
@@ -650,8 +650,8 @@ static int get_znodes_to_commit(struct ubifs_info *c)
dbg_cmt("no znodes to commit");
return 0;
}
- cnt += 1;
while (1) {
+ cnt += 1;
ubifs_assert(c, !ubifs_zn_cow(znode));
__set_bit(COW_ZNODE, &znode->flags);
znode->alt = 0;
@@ -664,7 +664,6 @@ static int get_znodes_to_commit(struct ubifs_info *c)
znode->ciip = znode->iip;
znode->cnext = cnext;
znode = cnext;
- cnt += 1;
}
dbg_cmt("committing %d znodes", cnt);
ubifs_assert(c, cnt == atomic_long_read(&c->dirty_zn_cnt));
--
2.39.2
More information about the linux-mtd
mailing list