[PATCH v4 2/2] dt-bindings: mtd: davinci: convert to yaml

Krzysztof Kozlowski krzk at kernel.org
Sun Oct 6 23:07:27 PDT 2024


On Sun, Oct 06, 2024 at 03:05:47PM +0200, Marcus Folkesson wrote:
> +  ti,davinci-nand-use-bbt:
> +    type: boolean
> +    description:
> +      Use flash based bad block table support. OOB identifier is saved in OOB
> +      area.
> +    deprecated: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - ti,davinci-chipselect
> +
> +additionalProperties: true

That's a final device schema, this cannot be true. Why you are doing
this entirely different than all other bindings?

You wrote in changelog, that you "silent the errors". Sorry, but that's
a no go. You are not suppose to silent them, but FIX THEM.


> +
> +examples:
> +  - |
> +    nand-controller at 2000000 {
> +      compatible = "ti,davinci-nand";
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      reg = <0 0x02000000>;

Keep order like in DTS coding style.

Best regards,
Krzysztof




More information about the linux-mtd mailing list