[PATCH] ubifs: fix uninitialized variable usage
Antonio Quartulli
antonio at mandelbit.com
Fri Nov 15 14:26:34 PST 2024
In ubifs_jnl_write_inode(), when an inode cannot be deleted
due to too many xattrs, err is passed to ubifs_ro_mode()
uninitialized, thus leading to bogus error reporting.
Fix this case by passing -EPERM, which is the same value that
ubifs_jnl_write_inode() is going to return to the caller.
This fixes 1 UNINIT issue reported by Coverity
Report: CID 1601860: Uninitialized scalar variable (UNINIT)
Cc: Richard Weinberger <richard at nod.at>
Cc: Zhihao Cheng <chengzhihao1 at huawei.com>
Cc: linux-kernel at vger.kernel.org (open list)
Signed-off-by: Antonio Quartulli <antonio at mandelbit.com>
---
fs/ubifs/journal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
index 8e98be642371..5eedf511880c 100644
--- a/fs/ubifs/journal.c
+++ b/fs/ubifs/journal.c
@@ -983,7 +983,7 @@ int ubifs_jnl_write_inode(struct ubifs_info *c, const struct inode *inode)
if (kill_xattrs && ui->xattr_cnt > ubifs_xattr_max_cnt(c)) {
ubifs_err(c, "Cannot delete inode, it has too much xattrs!");
- ubifs_ro_mode(c, err);
+ ubifs_ro_mode(c, -EPERM);
return -EPERM;
}
--
2.45.2
More information about the linux-mtd
mailing list