[PATCH v2 1/6] memory: ti-aemif: Create aemif_set_cs_timings()
Miquel Raynal
miquel.raynal at bootlin.com
Mon Nov 11 11:16:34 PST 2024
Hi Bastien,
2 very minor nits
> +/**
> + * struct aemif_cs_timings: structure to hold cs timing configuration
Nitpick: s/cs/CS/ in plain english?
...
> +/**
> + * aemif_set_cs_timings - Set the timing configuration of a given chip select.
> + * @aemif: aemif device to configure
> + * @cs: index of the chip select to configure.
Nit: Spurious dot ^
...
> - /* ... But configuring tighter timings is not an option. */
> - else if (result > max)
> - result = -EINVAL;
> -
Maybe this is too early to remove the check? If someone bisects and
falls in-between the patches of your series, NAND support would be
broken I guess?
With this fixed, feel free to add my:
Reviewed-by: Miquel Raynal <miquel.raynal at bootlin.com>
Thanks,
Miquèl
More information about the linux-mtd
mailing list