[PATCH 12/13] drm/xe/spi: add on-die spi device

[Krzysztof Kozlowski]

On 28/03/2024 13:22, Alexander Usyskin wrote:
> Signed-off-by: Alexander Usyskin <alexander.usyskin at intel.com>
> ---
>  drivers/gpu/drm/xe/Makefile          |  1 +
>  drivers/gpu/drm/xe/xe_device.c       |  3 ++
>  drivers/gpu/drm/xe/xe_device_types.h |  5 ++
>  drivers/gpu/drm/xe/xe_spi.c          | 78 ++++++++++++++++++++++++++++
>  drivers/gpu/drm/xe/xe_spi.h          | 15 ++++++
>  5 files changed, 102 insertions(+)
>  create mode 100644 drivers/gpu/drm/xe/xe_spi.c
>  create mode 100644 drivers/gpu/drm/xe/xe_spi.h


...

> +
> +void xe_spi_fini(struct xe_device *xe)
> +{
> +	struct intel_dg_spi_dev *spi = &xe->spi;
> +	struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
> +
> +	/* Only the DGFX devices have internal SPI */
> +	if (!IS_DGFX(xe))
> +		return;
> +
> +	dev_dbg(&pdev->dev, "removing xe-spi cell\n");

No need for simple functions entry/exit messages. There is already
infrastructure for this. Drop.

Best regards,
Krzysztof