[PATCH 3/5] spi: spi-qpic: Add qpic spi nand driver support
Md Sadre Alam
quic_mdalam at quicinc.com
Wed Mar 6 20:10:30 PST 2024
On 3/6/2024 9:57 PM, Konrad Dybcio wrote:
>
>
> On 3/6/24 07:01, Md Sadre Alam wrote:
>> Konrad,
>>
>> On 2/20/2024 5:44 PM, Md Sadre Alam wrote:
>>>>> + ecc_cfg->cfg0 = (cwperpage - 1) << CW_PER_PAGE
>>>>> + | ecc_cfg->cw_data << UD_SIZE_BYTES
>>>>> + | 1 << DISABLE_STATUS_AFTER_WRITE
>>>>> + | 3 << NUM_ADDR_CYCLES
>>>>> + | ecc_cfg->ecc_bytes_hw << ECC_PARITY_SIZE_BYTES_RS
>>>>> + | 0 << STATUS_BFR_READ
>>>>> + | 1 << SET_RD_MODE_AFTER_STATUS
>>>>> + | ecc_cfg->spare_bytes << SPARE_SIZE_BYTES;
>>>>
>>>> Let me introduce you to FIELD_PREP/GET and GENMASK().. Many assignments
>>>> in this file could use these.
>>>
>>> Ok
>>
>> While doing the change i realized that it will impact raw nand driver as well.
>> Shall I post this change as separate patch. Is this ok? Please let me know.
>
> One patch per file/topic, yes, please
Thank you
>
> Konrad
More information about the linux-mtd
mailing list