[PATCH v2] mtd: spi-nor: winbond: fix w25q128 regression

Pratyush Yadav pratyush at kernel.org
Fri Jun 21 08:50:45 PDT 2024


On Fri, Jun 21 2024, Michael Walle wrote:

> Commit 83e824a4a595 ("mtd: spi-nor: Correct flags for Winbond w25q128")
> removed the flags for non-SFDP devices. It was assumed that it wasn't in
> use anymore. This wasn't true. Add the no_sfdp_flags as well as the size
> again.
>
> We add the additional flags for dual and quad read because they have
> been reported to work properly by Hartmut using both older and newer
> versions of this flash, the similar flashes with 64Mbit and 256Mbit
> already have these flags and because it will (luckily) trigger our
> legacy SFDP parsing, so newer versions with SFDP support will still get
> the parameters from the SFDP tables.
>
> Reported-by: Hartmut Birr <e9hack at gmail.com>
> Closes: https://lore.kernel.org/r/CALxbwRo_-9CaJmt7r7ELgu+vOcgk=xZcGHobnKf=oT2=u4d4aA@mail.gmail.com/
> Fixes: 83e824a4a595 ("mtd: spi-nor: Correct flags for Winbond w25q128")
> Reviewed-by: Linus Walleij <linus.walleij at linaro.org>
> Signed-off-by: Michael Walle <mwalle at kernel.org>

Reviewed-by: Pratyush Yadav <pratyush at kernel.org>

Applied to spi-nor/next. Thanks!

-- 
Regards,
Pratyush Yadav



More information about the linux-mtd mailing list