[PATCH 20/24] spi: spi-mem: Reorder SPI_MEM_OP_CMD internals
Miquel Raynal
miquel.raynal at bootlin.com
Fri Dec 13 04:05:55 PST 2024
>> #define SPI_MEM_OP_CMD(__opcode, __buswidth) \
>> { \
>> - .buswidth = __buswidth, \
>> - .opcode = __opcode, \
>> .nbytes = 1, \
>> + .opcode = __opcode, \
>> + .buswidth = __buswidth, \
>> }
>>
>
> I don't mind, but shouldn't we follow the order used at struct declaration?
>
> struct spi_mem_op {
> struct {
> u8 nbytes;
> u8 buswidth;
> u8 dtr : 1;
> u8 __pad : 7;
> u16 opcode;
> } cmd;
Sure, let's do that. I also corrected the other macros at the same time (v2).
More information about the linux-mtd
mailing list