[PATCH v3 2/2] ubi: Implement ioctl for detailed erase counters
Rickard x Andersson
rickaran at axis.com
Mon Dec 9 01:38:39 PST 2024
On 12/7/24 09:06, Richard Weinberger wrote:
> ----- Ursprüngliche Mail -----
>> Von: "chengzhihao1" <chengzhihao1 at huawei.com>
>> An: "Rickard X Andersson" <rickard.andersson at axis.com>, "richard" <richard at nod.at>, "linux-mtd"
>> 在 2024/12/6 19:51, Rickard Andersson 写道:
>>> Currently, "max_ec" can be read from sysfs, which provides a limited
>>> view of the flash device’s wear. In certain cases, such as bugs in
>>> the wear-leveling algorithm, specific blocks can be worn down more
>>> than others, resulting in uneven wear distribution. Also some use cases
>>> can wear the erase blocks of the fastmap area more heavily than other
>>> parts of flash.
>>> Providing detailed erase counter values give a better understanding of
>>> the overall flash wear and is needed to be able to calculate for example
>>> expected life time.
>>> There exists more detailed info in debugfs, but this information is
>>> only available for debug builds.
>>>
>>> Signed-off-by: Rickard Andersson <rickard.andersson at axis.com>
>>> ---
>>> drivers/mtd/ubi/cdev.c | 72 ++++++++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 72 insertions(+)
>>
>> Hi Rickard. Some small nits below.
>
> Please also run checkpatch.pl, there are some coding style issues.
> Overall the change looks good to me and can be merged soon!
I have actually been running checkpatch.pl, but it gives no warnings or
errors.
Best regards,
Rickard A.
More information about the linux-mtd
mailing list