[PATCH mtd-utils 09/10] mtd-tests: flash_speed: Drop read_eraseblock_by_page()

Miquel Raynal miquel.raynal at bootlin.com
Mon Aug 26 02:46:28 PDT 2024


The read_eraseblock_by_2pages() has been generalized so it became
read_eraseblock_by_npages(), but there is no limitation (besides 0)
regarding the number of pages. Hence, drop the _by_page() helper and
replace it with the _by_npages(), using 'npages = 1'.

Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>
---
 tests/mtd-tests/flash_speed.c | 21 ++-------------------
 1 file changed, 2 insertions(+), 19 deletions(-)

diff --git a/tests/mtd-tests/flash_speed.c b/tests/mtd-tests/flash_speed.c
index 6df0568..1064491 100644
--- a/tests/mtd-tests/flash_speed.c
+++ b/tests/mtd-tests/flash_speed.c
@@ -233,24 +233,6 @@ static int write_eraseblock_by_2pages(int ebnum)
 	return err;
 }
 
-static int read_eraseblock_by_page(int ebnum)
-{
-	void *buf = iobuf;
-	int i, err = 0;
-
-	for (i = 0; i < pgcnt; ++i) {
-		err = mtd_read(&mtd, fd, ebnum, i * pgsize, iobuf, pgsize);
-		if (err) {
-			fprintf(stderr, "Error reading block %d, page %d!\n",
-					ebnum, i);
-			break;
-		}
-		buf += pgsize;
-	}
-
-	return err;
-}
-
 static int read_eraseblock_by_npages(int ebnum)
 {
 	int i, n = pgcnt / npages, err = 0;
@@ -454,7 +436,8 @@ int main(int argc, char **argv)
 
 	/* Read all eraseblocks, 1 page at a time */
 	puts("testing page read speed");
-	TIME_OP_PER_PEB(read_eraseblock_by_page, 1);
+	npages = 1;
+	TIME_OP_PER_PEB(read_eraseblock_by_npages, npages);
 	printf("page read speed is %ld KiB/s\n", speed);
 
 	/* Write all eraseblocks, 2 pages at a time */
-- 
2.43.0




More information about the linux-mtd mailing list