[PATCH v8 1/2] dt-bindings: mtd: Add Loongson-1 NAND Controller
Miquel Raynal
miquel.raynal at bootlin.com
Wed Aug 14 00:12:31 PDT 2024
Hi,
> > > When I first read "nfc" here I thought it was a copy-paste mistake, as
> > > "nfc" is a technology of it's own. I think it would make sense to rename
> > > to "loongson,ls1b-nand-controller" etc to remove that sort of confusion.
> > > These devices might not implement NFC, but what's to say that a future
> > > device will not?
I believe the nfc (also, nc) abbreviation pre-dates the NFC spec. But I
agree, it may be misleading. Even though I don't foresee any NAND
controller with NFC coming, it's probably bad for newcomers/people who
are not already deeply into the mtd details to use these confusing
letters, especially in a binding.
So, Ack.
> > Sorry for the confusion.
> > The string "loongson,ls1b-nand-controller" might be too long.
>
> It "might"? Why do you think it is too long?
Yeah, why would it be too long? Let's call a cat a cat. This is a
compatible for a NAND controller. So I expect the string to mention
it's a NAND controller because it's clearer. For quite some time there
has been a confusion between the NAND controller and the NAND
flash/chip, but these are two different hardware components.
> > May I rename it to "loongson,ls1b-nand"?
For the above reason, no :)
Thanks,
Miquèl
More information about the linux-mtd
mailing list