[PATCH 14/30] jffs2: Remove calls to set/clear the folio error flag

Richard Weinberger richard at nod.at
Mon Apr 22 08:56:21 PDT 2024


----- Ursprüngliche Mail -----
> Von: "chengzhihao1" <chengzhihao1 at huawei.com>
> An: "Matthew Wilcox" <willy at infradead.org>, "linux-fsdevel" <linux-fsdevel at vger.kernel.org>
> CC: "David Woodhouse" <dwmw2 at infradead.org>, "richard" <richard at nod.at>, "linux-mtd" <linux-mtd at lists.infradead.org>
> Gesendet: Montag, 22. April 2024 16:46:37
> Betreff: Re: [PATCH 14/30] jffs2: Remove calls to set/clear the folio error flag

> 在 2024/4/20 10:50, Matthew Wilcox (Oracle) 写道:
>> Nobody checks the error flag on jffs2 folios, so stop setting and
>> clearing it.  We can also remove the call to clear the uptodate
>> flag; it will already be clear.
>> 
>> Convert one of these into a call to mapping_set_error() which will
>> actually be checked by other parts of the kernel.
>> 
>> Cc: David Woodhouse <dwmw2 at infradead.org>
>> Cc: Richard Weinberger <richard at nod.at>
>> Cc: linux-mtd at lists.infradead.org
>> Signed-off-by: Matthew Wilcox (Oracle) <willy at infradead.org>
>> ---
>>   fs/jffs2/file.c | 14 +++-----------
>>   1 file changed, 3 insertions(+), 11 deletions(-)
> 
> xfstests passed. Looks like the change is harmless.
> 
> Tested-by: Reviewed-by: Zhihao Cheng <chengzhihao1 at huawei.com>

Acked-by: Richard Weinberger <richard at nod.at>

Thanks,
//richard



More information about the linux-mtd mailing list