[PATCH 01/13] spi: add auxiliary device for intel dg spi

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Thu Apr 11 06:51:29 PDT 2024


On 11/04/2024 15:43, Usyskin, Alexander wrote:
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>> Sent: Friday, March 29, 2024 15:47
>> To: Usyskin, Alexander <alexander.usyskin at intel.com>; Miquel Raynal
>> <miquel.raynal at bootlin.com>; Richard Weinberger <richard at nod.at>; Vignesh
>> Raghavendra <vigneshr at ti.com>; Jani Nikula <jani.nikula at linux.intel.com>;
>> Joonas Lahtinen <joonas.lahtinen at linux.intel.com>; Vivi, Rodrigo
>> <rodrigo.vivi at intel.com>
>> Cc: Lubart, Vitaly <vitaly.lubart at intel.com>; linux-mtd at lists.infradead.org; intel-
>> gfx at lists.freedesktop.org
>> Subject: Re: [PATCH 01/13] spi: add auxiliary device for intel dg spi
>>
>> On 28/03/2024 13:22, Alexander Usyskin wrote:
>>> Add auxilary bus device structure for
>>> Intel Discrete Graphics SPI device.
>>>
>>> Signed-off-by: Alexander Usyskin <alexander.usyskin at intel.com>
>>> ---
>>>  include/linux/intel_dg_spi_aux.h | 27 +++++++++++++++++++++++++++
>>
>> There is no user of this header. Please add it in the patch which uses it.
>>
> This header describes auxiliary device that bridges between
> i915 or Xe driver with spi-intel-dg driver.

There is no driver here, just simple header.

> This header included in both drivers; this is the reason this header
> has its own patch.

Does it mean your patchset is going through different trees?

> 
>> It will also justify why you use this or other subject prefix. Now, it
>> looks just wrong: it's not a patch for spi.
>>
> Can you suggest what subject prefix to use?
> Like: "auxiliary:"? Something else?

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.

> 

Best regards,
Krzysztof




More information about the linux-mtd mailing list