[PATCH v2 17/41] mtd: spi-nor: atmel: convert flash_info to new format

Michael Walle mwalle at kernel.org
Thu Sep 7 01:13:50 PDT 2023


>> +	{
>> +		.id = SNOR_ID(0x1f, 0x66, 0x01),
>> +		.name = "at25fs010",
> 
> nitpick, we shall respect the order of the members declared in
> flash_info struct.

As mentioned in my first reply, you're fine with keeping the id
first? After this series, we can swap the name and id members in
struct flash_info.

For all the other members, they should be used consistently. So
we could also swap the members in flash_info.

> And I'll let you double check if the conversion is accurate :D.
> 
> Reviewed-by: Tudor Ambarus <tudor.ambarus at linaro.org>

So I'll convert that one in an Acked-by: for all the conversion
patches?

-michael



More information about the linux-mtd mailing list