[RFC PATCH 2/5] arm64: dts: qcom: ipq9574: Add ecc engine support
Konrad Dybcio
konrad.dybcio at linaro.org
Tue Oct 31 08:23:19 PDT 2023
On 31.10.2023 13:03, Md Sadre Alam wrote:
> Signed-off-by: Md Sadre Alam <quic_mdalam at quicinc.com>
> Signed-off-by: Sricharan R <quic_srichara at quicinc.com>
> ---
Hello,
you're missing:
- dt-bindings (make dtbs_check is unhappy)
- a commit message
- Co-developed-by for Sricharan
status should read "okay" instead, but in this case it's unnecessary
as you're defining the node and lack of the status property also means
that device is enabled
however
this ECC engine seems to be a part of the NAND controller, so it's
unlikely that the DT maintainers will agree for it to have a separate
node
Konrad
> arch/arm64/boot/dts/qcom/ipq9574.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index 5f83ee42a719..b44acb1fac74 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -336,6 +336,11 @@ sdhc_1: mmc at 7804000 {
> status = "disabled";
> };
>
> + bch: qpic_ecc {
> + compatible = "qcom,ipq9574-ecc";
> + status = "ok";
> + }
> +
> blsp_dma: dma-controller at 7884000 {
> compatible = "qcom,bam-v1.7.0";
> reg = <0x07884000 0x2b000>;
More information about the linux-mtd
mailing list