[PATCH v2 3/4] mtd: rawnand: brcmnand: pass host struct to bcmnand_ctrl_poll_status

dregan at mail.com dregan at mail.com
Thu Oct 12 10:53:19 PDT 2023


Hi Miquel,

>
> Hi,
> 
> dregan at mail.com wrote on Thu, 12 Oct 2023 02:41:48 +0200:
> 
> > pass host struct to bcmnand_ctrl_poll_status instead of ctrl struct,
> 
> Capital letter

Will fix.

> 
> > since real time status requires host, and ctrl is a member of host.
> 
> real time status? I'm sorry this commit log is not very clear.

I can use this as the explanation:

Pass host struct to bcmnand_ctrl_poll_status instead of ctrl struct
since real time status requires host, and ctrl is a member of host.
Real time status is required for low level commands vs cached status
since the NAND controller will not do an automatic status read at the
end of a low level command as it would with a higher level command.

> 
> > 
> > Signed-off-by: David Regan <dregan at mail.com>
> > 
> 
> This new line should be dropped (in all your commit logs)

I'll remove these.

> 
> > ---
> > 
> > Changes in v2: added this patch in series
> 
> The versioning is wrong btw, you should continuously increase the
> counter, this is not just your second version. And as I said please use
> b4 or git-send-email so patches 2+ are answers of patch 1 and in my
> inbox it looks like 4 related patches instead.

Looks like I still need to work on this.

> 
> Thanks,
> Miquèl
> 

Thanks!

-Dave



More information about the linux-mtd mailing list