[PATCH] mtd: rawnand: cadence: Annotate struct cdns_nand_chip with __counted_by

Gustavo A. R. Silva gustavo at embeddedor.com
Fri Oct 6 13:48:29 PDT 2023



On 10/6/23 22:17, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
> array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct cdns_nand_chip.
> 
> Cc: Miquel Raynal <miquel.raynal at bootlin.com>
> Cc: Richard Weinberger <richard at nod.at>
> Cc: Vignesh Raghavendra <vigneshr at ti.com>
> Cc: "Gustavo A. R. Silva" <gustavoars at kernel.org>
> Cc: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
> Cc: Nicolas Ferre <nicolas.ferre at microchip.com>
> Cc: Roger Quadros <rogerq at kernel.org>
> Cc: Thierry Reding <treding at nvidia.com>
> Cc: Yang Yingliang <yangyingliang at huawei.com>
> Cc: "Uwe Kleine-König" <u.kleine-koenig at pengutronix.de>
> Cc: Valentin Korenblit <vkorenblit at sequans.com>
> Cc: ye xingchen <ye.xingchen at zte.com.cn>
> Cc: linux-mtd at lists.infradead.org
> Cc: linux-hardening at vger.kernel.org
> Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci [1]
> Signed-off-by: Kees Cook <keescook at chromium.org>

Reviewed-by: Gustavo A. R. Silva <gustavoars at kernel.org>

Thanks!
-- 
Gustavo

> ---
>   drivers/mtd/nand/raw/cadence-nand-controller.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/cadence-nand-controller.c b/drivers/mtd/nand/raw/cadence-nand-controller.c
> index 034ec564c2ed..7d5ef7ffe0fe 100644
> --- a/drivers/mtd/nand/raw/cadence-nand-controller.c
> +++ b/drivers/mtd/nand/raw/cadence-nand-controller.c
> @@ -526,7 +526,7 @@ struct cdns_nand_chip {
>   	/* ECC strength index. */
>   	u8 corr_str_idx;
>   
> -	u8 cs[];
> +	u8 cs[] __counted_by(nsels);
>   };
>   
>   struct ecc_info {



More information about the linux-mtd mailing list