[PATCH v5 6/6] mtd: spi-nor: add support for Macronix Octal flash

[Tudor Ambarus]

On 11/21/23 08:51, Michael Walle wrote:
> Hi Jaime,
> 
> [please keep the CC list in replies].
> 
>>> and sometimes incorrect. Therefore, at least drop it and just list the
>>> IDs.
>> Could I know patch 6/6 only or patch 5/6 should remove name as well?
> 
> I'd say yes. Tudor? Pratyush? New flash additions without names?

Why do you need a flash addition in the first place? Haven't we agreed
that we'll apply the vendor fixup based on the manufacturer ID?

Anyway, flash additions without names is fine by me.

Cheers,
ta
> 
> As, mentioned last time, for OF we might introduce an of_compatible
> (thats then ABI) - or - we can use the numeric ID in the device tree,
> as it's already used for PHY IDs or PCI IDs.
> 
> Jaime, could you try to use
> 
> /* Apply vendor fixups */
> { .id = SNOR_ID(0xc2) }
> 
> -michael