[PATCH v5 0/6] Add octal DTR support for Macronix flash

[liao jaime]

Hi Michael

>
> Hi,
>
> >> > Add method for Macronix Octal DTR Eable/Disable.
> >> > Merge Tudor's patch "Allow specifying the byte order in DTR mode"
> >> > Add support for Macronix flash
> >>
> >> I skimmed over the patches and they look good, but where is the
> >> controller part of this? I.e. which driver is using the dtr_swab16
> >> bit?
> >> There should be a working setup.
> > I think controller should info dtr_swab16 support in
> > spi_controller_mem_caps.
> > 8d-8d-8d will not be enable if the flash swap bytes and controller
> > driver not support
> > dtr_swab16.
>
> What I meant is that this patchset is missing a driver for the
> controller.
> Which controller does support it? We don't add code which is then not
> used
> at all. Or what I am missing here?
For this part, I validated on macronix spi host controller(spi-mxic.c).
I add ".dtr_swab16 = true;" in mxic_spi_mem_caps for patchset validation.
Do you mean that I need to patch dtr_swab16 support for spi-mxic.c as well?

>
> -michael

Thanks
Jaime