[PATCH 1/4] mtd: rawnand: brcmnand: Convert to platform remove callback returning void
Miquel Raynal
miquel.raynal at bootlin.com
Mon Nov 13 03:12:38 PST 2023
On Thu, 2023-11-02 at 22:02:48 UTC, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> By changing the function brcmnand_remove() to return void several
> drivers that use this function as remove callback can be converted to
> .remove_new().
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> Reviewed-by: Florian Fainelli <florian.fainelli at broadcom.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
More information about the linux-mtd
mailing list