[PATCH 0/2] mtd: hyperbus: Add support for Infineon S26Hx-T

[Tudor Ambarus]

Hi, Takahiro, Vignesh,


On 07.04.2023 09:11, tkuw584924 at gmail.com wrote:
> From: Takahiro Kuwano <Takahiro.Kuwano at infineon.com>
> 
> This sereis adds support for Infineon S26HL-T/S26HS-T flash family.
> https://www.infineon.com/dgdl/Infineon-S26HS01GTGABHM020-DataSheet-v01_00-EN.pdf?fileId=8ac78c8c7f2a768a017f52f2f5182c91
> 
> This family supports two interface modes, SPI mode and Hyperbus mode. The mode
> can be switched at rutime. The default mode is selected by ordering option
> and non-volatile user configuration. In hyperbus mode, the device is compatible
> with S26KL-S/S26KS-S hyperflash family that supports hyperbus only so one of
> use cases of S26Hx-T is replacement of (or migration from) S26Kx-S. This patch
> set focuses on particular usage that the device is pre-configured as hyperbus
> mode for compatibility with S26Kx-S.

I'm questioning the overall hyperbus software architecture, not your
patches per se. IMO hyperbus framework should have been written on top
of SPIMEM and the controllers be placed in drivers/spi/. So I'd first
address the SPIMEM adoption before adding/accepting new support. Would
love to hear more from Vignesh.

Cheers,
ta