[PATCH] ubifs: Free memory for tmpfile name

Mårten Lindahl marten.lindahl at axis.com
Wed Mar 29 06:26:53 PDT 2023

When opening a ubifs tmpfile on an encrypted directory, function
fscrypt_setup_filename allocates memory for the name that is to be
stored in the directory entry, but after the name has been copied to the
directory entry inode, the memory is not freed.

When running kmemleak on it we see that it is registered as a leak. The
report below is triggered by a simple program 'tmpfile' just opening a

  unreferenced object 0xffff88810178f380 (size 32):
    comm "tmpfile", pid 509, jiffies 4294934744 (age 1524.742s)

Free this memory after it has been copied to the inode.

Signed-off-by: Mårten Lindahl <marten.lindahl at axis.com>
 fs/ubifs/dir.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index 0f29cf201136..089ca6910124 100644
--- a/fs/ubifs/dir.c
+++ b/fs/ubifs/dir.c
@@ -491,6 +491,7 @@ static int ubifs_tmpfile(struct user_namespace *mnt_userns, struct inode *dir,
 		goto out_cancel;
 	unlock_2_inodes(dir, inode);
+	fscrypt_free_filename(&nm);
 	ubifs_release_budget(c, &req);
 	return finish_open_simple(file, 0);

base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c
change-id: 20230329-memleak-fix-87a01daf469e

Best regards,
Mårten Lindahl <marten.lindahl at axis.com>

More information about the linux-mtd mailing list