[PATCH] mtd: nand: qcom: Use of_property_present() for testing DT property presence
Manivannan Sadhasivam
mani at kernel.org
Fri Mar 10 06:55:45 PST 2023
On Fri, Mar 10, 2023 at 08:47:15AM -0600, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
>
> Signed-off-by: Rob Herring <robh at kernel.org>
Reviewed-by: Manivannan Sadhasivam <mani at kernel.org>
Thanks,
Mani
> ---
> drivers/mtd/nand/raw/qcom_nandc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
> index 198a44794d2d..6b52ed8c6178 100644
> --- a/drivers/mtd/nand/raw/qcom_nandc.c
> +++ b/drivers/mtd/nand/raw/qcom_nandc.c
> @@ -3054,7 +3054,7 @@ static int qcom_nand_host_parse_boot_partitions(struct qcom_nand_controller *nan
> struct device *dev = nandc->dev;
> int partitions_count, i, j, ret;
>
> - if (!of_find_property(dn, "qcom,boot-partitions", NULL))
> + if (!of_property_present(dn, "qcom,boot-partitions"))
> return 0;
>
> partitions_count = of_property_count_u32_elems(dn, "qcom,boot-partitions");
> --
> 2.39.2
>
--
மணிவண்ணன் சதாசிவம்
More information about the linux-mtd
mailing list