[PATCH v2 2/2] mtd: spi-nor: Drop redundant information on the sst26vf flash series

Tudor Ambarus tudor.ambarus at linaro.org
Mon Jun 19 01:20:49 PDT 2023



On 6/16/23 15:08, Miquel Raynal wrote:
> It seems like the whole sst26vf flash series share the exact same
> properties, beside the final size due to a lower/higher number of blocks
> in the final die. As the intermediate version fully supports SFDP
> parsing, we assume the others as well.

I think the changes are fine, but I'm not going to queue things
that are not tested. I saw too many things to rely on assumptions.
All these will be changed one at a time when we have hw on our hands.

> 
> Drop the redundant information and use the PARSE_SFDP flag instead.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>
> ---
>  drivers/mtd/spi-nor/sst.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mtd/spi-nor/sst.c b/drivers/mtd/spi-nor/sst.c
> index 48970d2f78fa..467154176dd6 100644
> --- a/drivers/mtd/spi-nor/sst.c
> +++ b/drivers/mtd/spi-nor/sst.c
> @@ -109,17 +109,17 @@ static const struct flash_info sst_nor_parts[] = {
>  	{ "sst26wf016b", INFO(0xbf2651, 0, 64 * 1024, 32)
>  		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
>  			      SPI_NOR_QUAD_READ) },
> -	{ "sst26vf016b", INFO(0xbf2641, 0, 64 * 1024, 32)
> +	{ "sst26vf016b", INFO(0xbf2641, 0, 0, 0)
>  		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
> -		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ)
> +		PARSE_SFDP
>  		.fixups = &sst26vf_nor_fixups },
>  	{ "sst26vf032b", INFO(0xbf2642, 0, 0, 0)
>  		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
>  		PARSE_SFDP
>  		.fixups = &sst26vf_nor_fixups },
> -	{ "sst26vf064b", INFO(0xbf2643, 0, 64 * 1024, 128)
> +	{ "sst26vf064b", INFO(0xbf2643, 0, 0, 0)
>  		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
> -		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
> +		PARSE_SFDP
>  		.fixups = &sst26vf_nor_fixups },
>  };
>  



More information about the linux-mtd mailing list