[PATCH v2 02/17] dt-bindings: mtd: Create a file for raw NAND chip properties
Miquel Raynal
miquel.raynal at bootlin.com
Sun Jun 18 23:59:07 PDT 2023
Hi Krzysztof,
krzk at kernel.org wrote on Mon, 19 Jun 2023 08:28:28 +0200:
> On 06/06/2023 19:52, Miquel Raynal wrote:
> > In an effort to constrain as much as we can the existing binding, we
> > want to add "unevaluatedProperties: false" in all the NAND chip
> > descriptions part of NAND controller bindings. But in order to do that
> > properly, we also need to reference a file which contains all the
> > "allowed" properties. Right now this file is nand-chip.yaml but in
> > practice raw NAND controllers may use additional properties in their
> > NAND chip children node. These properties are listed under
> > nand-controller.yaml, which makes the "unevaluatedProperties" checks
> > fail while the description are valid. We need to move these NAND chip
> > related properties into another file, because we do not want to pollute
> > nand-chip.yaml which is also referenced by eg. SPI-NAND devices.
> >
> > Let's create a raw-nand-chip.yaml file to reference all the properties a
> > raw NAND chip description can contain. The chain of inheritance becomes:
> > nand-controller.yaml <- raw-nand-chip.yaml
> > raw-nand-chip.yaml <- nand-chip.yaml
> > spi-nand.yaml <- nand-chip.yaml
>
> ...
>
> > - The interpretation of these parameters is implementation-defined, so
> > - not all implementations must support all possible
> > - combinations. However, implementations are encouraged to further
> > - specify the value(s) they support.
> > -
> > properties:
> > $nodename:
> > pattern: "^nand-controller(@.*)?"
> > @@ -51,79 +41,8 @@ properties:
> >
> > patternProperties:
> > "^nand@[a-f0-9]$":
> > - $ref: "nand-chip.yaml#"
>
> You work on some old tree, judging by email addresses you CC and by
> this. I would expect here current next, but this is even pre v6.4-rc1!
> Working on something older than current master branch doss not make any
> sense.
This is really based on v6.4-rc1, I think Rob's tooling is applying the
patches against -rc1 so I try to keep the robots happy by picking that
tag as base. I know you are removing the quotes so I went through my
series and dropped them from all the files which now reference
raw-nand-chip.yaml, but of course I missed that one, I am sorry, I will
drop the quotes here as well.
Thanks,
Miquèl
More information about the linux-mtd
mailing list