[PATCH v2 1/2] mtd: spi-nor: add Octal DTR support for Macronix flash

[Tudor Ambarus]

On 7/28/23 10:46, Michael Walle wrote:
> Hi,
> 
>>>> +    /* Macronix SPI-NOR flash 8D-8D-8D read ID would get 6 bytes data A-A-B-B-C-C */
>>>> +    for (i = 0; i < nor->info->id_len; i++)
>>>> +        if (buf[i * 2] != nor->info->id[i])
>>>> +            return -EINVAL;
>>
>> We need some kind of per flash rdid override. I guess rdid won't work
>> in octal mode then. Are any other commands also affected?
> 
> Jaime was kind enough to send me some datasheets and it looks like
> some commands will return the response bytes in STR mode. So,
> technically, the correct thing to do here would be to use
> 8D-8D-8S mode. Other commands will also respond in STR mode, but
> I guess we don't notice because most of them are just one byte.
> But I think we should get this correct in the core.
> 

happy to get patches for review!