[PATCH] mtd: fix use-after-free in mtd release

Miquel Raynal miquel.raynal at bootlin.com
Thu Jul 27 09:36:11 PDT 2023


Hi Andy,

andriy.shevchenko at linux.intel.com wrote on Thu, 27 Jul 2023 18:58:29
+0300:

> On Thu, Jul 27, 2023 at 05:20:13PM +0200, Miquel Raynal wrote:
> > andriy.shevchenko at linux.intel.com wrote on Thu, 27 Jul 2023 18:12:04
> > +0300:  
> > > On Thu, Jul 27, 2023 at 05:57:58PM +0300, Alexander Usyskin wrote:  
> 
> ...
> 
> > > > Fixes: 19bfa9ebebb5 ("mtd: use refcount to prevent corruption")  
> > > 
> > > Closes: ?  
> > 
> > Did I miss a recent update on the use of Fixes?  
> 
> They are orthogonal to each other. Actually Closes goes closer with
> Reported-by.
> 
> I believe both of them needs to be added (by I might miss something).
> 
> > I thought Closes was
> > supposed to point at a bug report while Fixes would point to the faulty
> > commit.  
> 
> Correct.
> 
> > Right now I feel like Fixes is the right tag,  
> 
> Nobody objects that (see above).
> 
> > but if you have a source explaining why we should not longer do it like
> > I am used to, I would appreciate a link.  
> 
> Since you know about Closes already, I think there is nothing to add.

Ah sorry I misunderstood your first e-mail. I thought you were
suggesting to replace Fixes by Closes. Sorry for the misunderstanding :)

Thanks,
Miquèl



More information about the linux-mtd mailing list