[PATCH v2 2/2] mtd: spi-nor: add support for Macronix Octal flash

[Michael Walle]

Am 2023-07-27 12:10, schrieb Tudor Ambarus:
> On 7/27/23 11:04, Michael Walle wrote:
>> Hi,
>> 
>>>> +    { "mx66uw2g345gx0", INFOB(0xc2943c, 0, 0, 0, 4)
>>>> +        FLAGS(SPI_NOR_RWW)
>>>> +        NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_READ | 
>>>> SPI_NOR_OCTAL_DTR_READ |
>>>> +                  SPI_NOR_OCTAL_DTR_PP) },
>>>> +    { "mx25uw51345g", INFOB(0xc2843a, 0, 0, 0, 4)
>>>> +        FLAGS(SPI_NOR_RWW)
>>>> +        NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ | 
>>>> SPI_NOR_OCTAL_DTR_PP) },
>>>> +    { "mx25um25345g", INFO(0xc28339, 0, 0, 0)
>>>> +        NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ | 
>>>> SPI_NOR_OCTAL_DTR_PP) },
>>>> +    { "mx25uw25345g", INFOB(0xc28439, 0, 0, 0, 4)
>>>> +        FLAGS(SPI_NOR_RWW)
>>>> +        NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ | 
>>>> SPI_NOR_OCTAL_DTR_PP) },
>>>> +    { "mx25uw12345g", INFOB(0xc28438, 0, 0, 0, 4)
>>>> +        FLAGS(SPI_NOR_RWW)
>>>> +        NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ | 
>>>> SPI_NOR_OCTAL_DTR_PP) },
>>>> +    { "mx25uw6345g", INFOB(0xc28437, 0, 0, 0, 4)
>>>> +        FLAGS(SPI_NOR_RWW)
>>>> +        NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ | 
>>>> SPI_NOR_OCTAL_DTR_PP) },
>>> 
>>> PARSE_SFDP for all the flashes please.
>> 
>> And no NO_SFDP_FLAGS() as discussed.
>> 
> 
> Are there flavors of these flashes that don't support SFDP,
> or why did you ask for NO_SFDP_FLAGS? Do each of these flashes
> have SFDP and no-SFDP flavors?

I asked to drop NO_SFDP_FLAGS().

-michael