[PATCH v3] mtd: spi-nor: fix memory leak when using debugfs_lookup()

Michael Walle michael at walle.cc
Wed Feb 8 07:28:45 PST 2023


> +static void __exit spi_nor_module_exit(void)
> +{
> +	spi_nor_debugfs_shutdown();
> +	spi_mem_driver_unregister(&spi_nor_driver);

Hm, does the order matter here? I didn't test it, but this will
lead to:

rootdir = debugfs_create_dir("spi-nor", NULL);
nor->debugfs_root = debugfs_create_dir("spi0", rootdir);
debugfs_remove(rootdir);
debugfs_remove(nor->debugfs_root);

If that's ok, then this looks good.

-michael



More information about the linux-mtd mailing list