[PATCH v6 5/7] spi: mxic: Add support for swapping byte

liao jaime jaimeliao.tw at gmail.com
Mon Dec 11 23:44:19 PST 2023


Hi Michael

>
> Hi,
>
> > I know for sure that mchp's sama7g5 xSPI controller can swap the bytes
> > back on the fly. What I did was to check the dtr_swab16 bool at runtime
> > in the exec_op() method and if it was true, I had to write a
> > configuration bit. I can't remember why I haven't posted a v2 on that
> > series, maybe I'll do it if I find some time or I ever get bored. I
> > have
> > a board. Anyway, knowing that there's a board out there, sama7g5ek,
> > that
> > contains a macronix flash that swaps bytes and also have a controller
> > that can swap them back, would it be acceptable to queue just the SPI
> > NOR patches for now?
>
> I'm still leaning towards not putting any unused code into the kernel
> and (maybe) increase maintenance. Or code which might need to be
> adjusted
> later if it will actually be used. Without a user, we won't see the
> whole picture and - at least I - cannot judge whether that approach is
> correct then.
>
> I'd say, if you ever get board, take this patch again together with the
> user :)
Is it necessary to prepare v7 or spi-nor patches will be accept?

>
> -michael

Thanks
Jaime



More information about the linux-mtd mailing list