[PATCH 20/49] mtd: rawnand: ingenic: Convert to platform remove callback returning void

Philippe Mathieu-Daudé philmd at linaro.org
Thu Apr 6 05:14:27 PDT 2023


On 1/4/23 18:19, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
>   drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd at linaro.org>




More information about the linux-mtd mailing list