[PATCH] Revert "mtd: spi-nor: core: Return error code from set_4byte_addr_mode()"

Mika Westerberg mika.westerberg at linux.intel.com
Thu Sep 22 07:16:12 PDT 2022


On Thu, Sep 22, 2022 at 04:12:17PM +0200, Michael Walle wrote:
> Am 2022-09-22 15:48, schrieb Mika Westerberg:
> > This reverts commit 08412e72afba3a2daef3e7f3378c3753255a0017.
> > 
> > The Intel SPI-NOR controller does not support this opcode so the driver
> > ends up returning -EOPNOTSUPP and that makes the SPI flash chip probe
> > fail like this:
> > 
> >   [ 12.291082] spi-nor: probe of spi0.0 failed with error -524
> > 
> > Whereas previously it worked just fine (and hence the return value
> > probably was ignored in the first place).
> 
> Can't we just ignore that return code then?

Isn't this revert just doing that? ;-)



More information about the linux-mtd mailing list