[PATCH] mtd: spi-nor: gigadevice: Add support for gd25lr256e

[Michael Walle]

Am 2022-09-22 15:56, schrieb Mika Westerberg:
> Add support for this 32MB serial flash.
> 
> Signed-off-by: Mika Westerberg <mika.westerberg at linux.intel.com>
> ---
>  drivers/mtd/spi-nor/gigadevice.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/gigadevice.c 
> b/drivers/mtd/spi-nor/gigadevice.c
> index 119b38e6fc2a..7a7f5cb67a9e 100644
> --- a/drivers/mtd/spi-nor/gigadevice.c
> +++ b/drivers/mtd/spi-nor/gigadevice.c
> @@ -57,6 +57,10 @@ static const struct flash_info 
> gigadevice_nor_parts[] = {
>  		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6)
>  		FIXUP_FLAGS(SPI_NOR_4B_OPCODES)
>  		.fixups = &gd25q256_fixups },
> +	{ "gd25lr256e", INFO(0xc86719, 0, 64 * 1024, 512)

There doesn't seem to be a public datasheet. Does this flash support 
SFDP?

In that case, please just use
	{ "gd25lr256e", INFO(0xc86719, 0, 0, 0),
		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
		PARSE_SFDP
	}

-michael

> +		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> +		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> +			      SPI_NOR_QUAD_READ) },
>  };
> 
>  const struct spi_nor_manufacturer spi_nor_gigadevice = {