[PATCH v3 1/2] dt-bindings: mtd: marvell-nand: Convert to YAML DT scheme
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Tue Oct 25 05:01:23 PDT 2022
On 24/10/2022 20:29, Vadym Kochan wrote:
> [...]
>
>>> + nand-ecc-step-size:
>>> + description: |
>>> + Marvell's NAND flash controller does use fixed strength
>>> + (1-bit for Hamming, 16-bit for BCH), so the actual step size
>>> + will shrink or grow in order to fit the required strength.
>>> + Step sizes are not completely random for all and follow certain
>>> + patterns described in AN-379, "Marvell SoC NFC ECC".
>>> +
>>> + label:
>>> + $ref: /schemas/types.yaml#/definitions/string
>>> +
>>> + partitions:
>>> + type: object
>>> + $ref: /schemas/mtd/partitions/partition.yaml
>>
>> This is a friendly reminder during the review process.
>>
>> It seems my previous comments were not fully addressed. Maybe my
>> feedback got lost between the quotes, maybe you just forgot to apply it.
>> Please go back to the previous discussion and either implement all
>> requested changes or keep discussing them.
>>
>> Thank you.
>>
>
> I see that I have to drop "label" and "partitions" properties.
Hm.... why?
I commented about missing unevaluatedProperties.
Best regards,
Krzysztof
More information about the linux-mtd
mailing list