[PATCH] mtd: rawnand: Drop obsolete dependencies on COMPILE_TEST

Jean Delvare jdelvare at suse.de
Thu Nov 24 02:59:46 PST 2022

Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.

Signed-off-by: Jean Delvare <jdelvare at suse.de>
Cc: Miquel Raynal <miquel.raynal at bootlin.com>
Cc: Richard Weinberger <richard at nod.at>
Cc: Vignesh Raghavendra <vigneshr at ti.com>
Cc: Naga Sureshkumar Relli <nagasure at xilinx.com>
 drivers/mtd/nand/raw/Kconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- linux-6.0.orig/drivers/mtd/nand/raw/Kconfig
+++ linux-6.0/drivers/mtd/nand/raw/Kconfig
@@ -435,7 +435,7 @@ config MTD_NAND_PLATFORM
 	tristate "Support Cadence NAND (HPNFC) controller"
-	depends on (OF || COMPILE_TEST) && HAS_IOMEM
+	depends on OF && HAS_IOMEM
 	  Enable the driver for NAND flash on platforms using a Cadence NAND
@@ -450,7 +450,7 @@ config MTD_NAND_ARASAN
 	tristate "Support for NAND controller on Intel LGM SoC"
-	depends on OF || COMPILE_TEST
+	depends on OF
 	depends on HAS_IOMEM
 	  Enables support for NAND Flash chips on Intel's LGM SoC.
@@ -470,7 +470,7 @@ config MTD_NAND_ROCKCHIP
 config MTD_NAND_PL35X
 	tristate "ARM PL35X NAND controller"
-	depends on OF || COMPILE_TEST
+	depends on OF
 	depends on PL353_SMC
 	  Enables support for PrimeCell SMC PL351 and PL353 NAND

Jean Delvare
SUSE L3 Support

More information about the linux-mtd mailing list