[PATCH] ubifs: Fix build errors as symbol undefined

Zhihao Cheng chengzhihao1 at huawei.com
Tue Nov 15 00:24:21 PST 2022


在 2022/11/15 16:33, Li Hua 写道:
> When CONFIG_UBIFS_FS is enable but CONFIG_UBIFS_FS_AUTHENTICATION is not set:
>      ERROR: modpost: "ubifs_bad_hash" [fs/ubifs/ubifs.ko] undefined!
> 
> Fixes: 16a26b20d2af ("ubifs: authentication: Add hashes to index nodes")
> Signed-off-by: Li Hua <hucool.lihua at huawei.com>
> ---
>   fs/ubifs/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/fs/ubifs/Kconfig b/fs/ubifs/Kconfig
> index 45d3d207fb99..93bda1057fdc 100644
> --- a/fs/ubifs/Kconfig
> +++ b/fs/ubifs/Kconfig
> @@ -13,6 +13,7 @@ config UBIFS_FS
>   	select CRYPTO_HASH_INFO
>   	select UBIFS_FS_XATTR if FS_ENCRYPTION
>   	select FS_ENCRYPTION_ALGS if FS_ENCRYPTION
> +	select UBIFS_FS_AUTHENTICATION

ubifs authentication is a submodule under ubifs.

I don't think ubifs authentication should be enabled automatically when 
ubifs is enabled. Linux users may only want to choose ubifs without 
authentication enabled.

>   	depends on MTD_UBI
>   	help
>   	  UBIFS is a file system for flash devices which works on top of UBI.
> @@ -91,6 +92,7 @@ config UBIFS_FS_AUTHENTICATION
>   	select KEYS
>   	select CRYPTO_HMAC
>   	select SYSTEM_DATA_VERIFICATION
> +	select SYSTEM_TRUSTED_KEYRING
>   	help
>   	  Enable authentication support for UBIFS. This feature offers protection
>   	  against offline changes for both data and metadata of the filesystem.
> 




More information about the linux-mtd mailing list