[PATCH] mtd-utils: nanddump: fix writing big images on 32bit machines
David Oberhollenzer
david.oberhollenzer at sigma-star.at
Wed Jun 8 00:56:07 PDT 2022
Applied to mtd-utils.git master
Thanks,
David
On 6/8/22 09:51, Sascha Hauer wrote:
> When writing a full 4GiB NAND to a file end_addr becomes 0x100000000.
> With that writing out the first page to the file doesn't happen
> because size_left is calculated to 0x100000000 - 0 = 0x100000000
> which is then truncated to 32bit and becomes zero. Fix this by
> using an appropriate 64bit type for size_left.
>
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> ---
> nand-utils/nanddump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/nand-utils/nanddump.c b/nand-utils/nanddump.c
> index d7fc320..47539f5 100644
> --- a/nand-utils/nanddump.c
> +++ b/nand-utils/nanddump.c
> @@ -499,7 +499,7 @@ int main(int argc, char * const argv[])
> }
> } else {
> /* Write requested length if oob is omitted */
> - size_t size_left = end_addr - ofs;
> + long long size_left = end_addr - ofs;
> if (omitoob && (size_left < bs))
> err = ofd_write(ofd, readbuf, size_left);
> else
More information about the linux-mtd
mailing list