[PATCH V3] mtd: spi-nor: winbond: Add support for winbond chip

[Sajida Bhanu (Temp)]

Hi,

Gentle Reminder.

Thanks,
Sajida
-----Original Message-----
From: Tudor.Ambarus at microchip.com <Tudor.Ambarus at microchip.com> 
Sent: Tuesday, December 14, 2021 4:46 PM
To: Sajida Bhanu (Temp) (QUIC) <quic_c_sbhanu at quicinc.com>; dianders at chromium.org; michael at walle.cc; p.yadav at ti.com; miquel.raynal at bootlin.com; richard at nod.at; vigneshr at ti.com; linux-mtd at lists.infradead.org; linux-kernel at vger.kernel.org
Cc: stummala at codeaurora.org; vbadigan at codeaurora.org; Ram Prakash Gupta (QUIC) <quic_rampraka at quicinc.com>; Pradeep Pragallapati (QUIC) <quic_pragalla at quicinc.com>; sartgarg at codeaurora.org
Subject: Re: [PATCH V3] mtd: spi-nor: winbond: Add support for winbond chip

WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.

On 12/14/21 12:16 PM, Shaik Sajida Bhanu wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know 
> the content is safe
>
> Add support for winbond W25Q512NW-IM chip.
>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu at quicinc.com>
> Reviewed-by: Doug Anderson <dianders at chromium.org>
> ---
> Changes since V1:
>         Added space before name of the flash part as suggested by Doug.
>
> Changes since V2:
>         Updated chip name as w25q512nwm as suggested by Doug.
> ---
>  drivers/mtd/spi-nor/winbond.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c 
> b/drivers/mtd/spi-nor/winbond.c index 96573f6..42d5800 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -100,6 +100,9 @@ static const struct flash_info winbond_parts[] = {
>                              SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>         { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
>                             SECT_4K | SPI_NOR_QUAD_READ | 
> SPI_NOR_DUAL_READ) },

This does not apply on current spi-nor/next. We've changed how the flash_info flags are handled. We also require to dump the SPI NOR sysfs entries under the comment section ---. I'll update the documentation to add some guidelines on how new flash additions or flash updates should be proposed. Sometime this week, or maybe next.

Cheers,
ta