[PATCH] mtd: rawnand: brcmnand: Fixed incorrect sub-page ECC status

Florian Fainelli f.fainelli at gmail.com
Wed Jan 12 20:58:06 PST 2022



On 1/12/2022 1:08 PM, david regan wrote:
> The brcmnand driver contains a bug in which if a page (example 2k byte)
> is read from the parallel/ONFI NAND and within that page a subpage (512
> byte) has correctable errors which is followed by a subpage with
> uncorrectable errors, the page read will return the wrong status of
> correctable (as opposed to the actual status of uncorrectable.)
> 
> The bug is in function brcmnand_read_by_pio where there is a check for
> uncorrectable bits which will be preempted if a previous status for
> correctable bits is detected.
> 
> The fix is to stop checking for bad bits only if we already have a bad
> bits status.
> 
> Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller")
> 
> Signed-off-by: david regan <dregan at mail.com>

Reviewed-by: Florian Fainelli <f.fainelli at gmail.com>

Thanks David!
-- 
Florian



More information about the linux-mtd mailing list