[PATCH v1 05/14] mtd: spi-nor: xilinx: rename vendor specific functions and defines

Michael Walle michael at walle.cc
Thu Feb 10 00:04:26 PST 2022


Am 2022-02-10 04:08, schrieb Tudor.Ambarus at microchip.com:
> On 2/2/22 16:58, Michael Walle wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know 
>> the content is safe
>> 
>> Drop the generic spi_nor prefix for all the xilinx functions.
> 
> mm, no, I would keep the spi_nor prefix because xilinx_sr_ready is too
> generic and can conflict with methods from other subsystems.

But all the other functions in this file start with xilinx_ ;)

I don't have a strong opinion here, other than it shouldn't
be called spi_nor_read_blaba() because that looks like a
standard spi nor function belonging in core.c

-michael



More information about the linux-mtd mailing list