[PATCH] mtd/memory: omap: Fix build dependencies

Nishanth Menon nm at ti.com
Wed Feb 9 07:21:07 PST 2022


On 16:39-20220209, Roger Quadros wrote:
> >>  config OMAP_GPMC
> >>  	bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
> >> -	depends on OF_ADDRESS
> > 
> > Thoughts Roger?
> 
> OMAP_GPMC is not visible entry so someone has to select it.
> We first tried selecting it in ARCH_K3 but that was not accepted for fair reason.
> Then we tried to select it from MTD_NAND_OMAP2 and it caused the issue this patch is trying to fix.
> 
> Only other option left is to make OMAP_GPMC a visible entry and just mark MTD_NAND_OMAP2 to depend on it?
> The relevant SoC defconfig files can enable OMAP_GPMC and MTD_NAND_OMAP2.
> 
> Does this sound ok?

Given that of_address.h is handling OF_ADDRESS smartly, and the fact
that there are quite the many drivers that are actually OF only, I am
not entirely sure why the dependency is needed in Kconfig, but that is
just me..

I'd suggest to see with the randconfig that Randy provided in [1]


[1] https://lore.kernel.org/all/b18fc937-9cc2-bb7b-fb58-3ba2555371c7@infradead.org/

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D



More information about the linux-mtd mailing list