[PATCH] [v2] mtd: cfi: allow building spi-intel standalone
tudor.ambarus at linaro.org
Tue Dec 20 22:49:59 PST 2022
On 20.12.2022 17:57, Miquel Raynal wrote:
> Hi Tudor,
> tudor.ambarus at linaro.org wrote on Tue, 20 Dec 2022 17:44:49 +0200:
>> Hi, Arnd,
>> On 20.12.2022 16:13, Arnd Bergmann wrote:
>>> From: Arnd Bergmann <arnd at arndb.de>
>>> When MTD or MTD_CFI_GEOMETRY is disabled, the spi-intel driver
>>> fails to build, as it includes the shared CFI header:
>>> include/linux/mtd/cfi.h:62:2: error: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work. [-Werror=cpp]
>>> 62 | #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work.
>>> linux/mtd/spi-nor.h does not actually need to include cfi.h, so
>>> remove the inclusion here to fix the warning. This uncovers a
>>> missing #include in spi-nor/core.c so add that there to
>>> prevent a different build issue.
>>> Fixes: e23e5a05d1fd ("mtd: spi-nor: intel-spi: Convert to SPI MEM")
>>> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
>> Looks good to me. I'll let the linux-0day bot run over it and apply it
>> once -rc1 is out.
> The issue sometimes produces build errors, shall I send it through a
> fixes PR instead?
Yes, that I was thinking about.
More information about the linux-mtd