[PATCH v4 8/8] memory: gpmc-omap: "gpmc, device-width" DT property is optional

Krzysztof Kozlowski krzysztof.kozlowski at canonical.com
Wed Sep 15 00:12:28 PDT 2021


On 14/09/2021 14:27, Roger Quadros wrote:
> Check for valid gpmc,device-width, nand-bus-width and bank-width
> at one place. Default to 8-bit width if none present.
> 
> Signed-off-by: Roger Quadros <rogerq at kernel.org>
> ---
>  drivers/memory/omap-gpmc.c | 41 ++++++++++++++++++++++++--------------
>  1 file changed, 26 insertions(+), 15 deletions(-)
> 

All the comments from v3 are still applicable because it seems you
ignored them. Please respond to them.

It's the second patch where the reviewer's comments got lost, so it
creates rather poor impression.


Best regards,
Krzysztof



More information about the linux-mtd mailing list