[PATCH 1/2] dt-bindings: mtd: brcmnand: add "no-wp" property

Rafał Miłecki rafal at milecki.pl
Mon Nov 8 23:49:36 PST 2021


On 03.11.2021 16:11, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal at milecki.pl>
> 
> It's required to properly describe boards without connected WP pin (e.g.
> Asus GT-AC5300).
> 
> Signed-off-by: Rafał Miłecki <rafal at milecki.pl>
> ---
>   Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> index dd5a64969e37..49c7860c0dad 100644
> --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> @@ -111,6 +111,11 @@ properties:
>         earlier versions of this core that include WP
>       type: boolean
>   
> +  no-wp:
> +    description:
> +      This property marks boards with WP pin not connected to the NAND chip.
> +    type: boolean

I started rethinking this. Since we already hav "brcm,nand-has-wp"
(boolean), would makes more sense:
1. Add "no-wp" boolean (as proposed in this patch)
2. Add "wp" (or similar) with [0, 1] and deprecate "brcm,nand-has-wp"



More information about the linux-mtd mailing list