[PATCH] mtd: spi-nor: intel-spi: Add support for second flash chip

[Pratyush Yadav]

Hi,

On 25/05/21 07:03PM, Mika Westerberg wrote:
> Intel SPI flash controller has been supporting two chip selects long
> time already even if the most common configuration is to have single
> flash chip for the BIOS and related data. This adds support for the
> second chip select if we find out that there are two flash components
> (this information is available in the mandatory flash descriptor on the
> first chip). The second chip is exposed as is without any partition
> information with name "chip1". The first chip continues work as is.
> 
> Signed-off-by: Mika Westerberg <mika.westerberg at linux.intel.com>
> ---
>  drivers/mtd/spi-nor/controllers/intel-spi.c | 208 ++++++++++++++------

Aren't the drivers in controllers/ supposed to move to use SPI MEM? I 
don't know if this has been discussed before, but I would like all 
drivers in controllers/ to move to SPI MEM API at some point in the 
future. This would let us drop support for this "legacy" controller API 
from SPI NOR, cleaning up the core quite a bit. No more if (nor->spimem) 
needed anywhere.

I wonder what other folks think about this. I vote for freezing all new 
features in controllers/. If you want something new, move to SPI MEM.

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.